Re: [PATCH] Replace HTTP links with HTTPS ones: Documentation/admin-guide

[Jonathan Corbet]

On Sun, 21 Jun 2020 15:20:49 +0200
"Alexander A. Klimov" <grandmaster@xxxxxxxxxxxx> wrote:

So for this one ...

> diff --git a/Documentation/admin-guide/README.rst b/Documentation/admin-guide/README.rst
> index 5fb526900023..7186ed9b42fe 100644
> --- a/Documentation/admin-guide/README.rst
> +++ b/Documentation/admin-guide/README.rst
> @@ -1,6 +1,6 @@
>  .. _readme:
>  
> -Linux kernel release 5.x <http://kernel.org/>
> +Linux kernel release 5.x <https://kernel.org/>
>  =============================================

I'd really rather just take that URL out of there, it makes no sense in the
heading. 

[...]

> index 9443fcef1876..bc3abfb33476 100644
> --- a/Documentation/admin-guide/ext4.rst
> +++ b/Documentation/admin-guide/ext4.rst
> @@ -611,7 +611,7 @@ kernel source:	<file:fs/ext4/>
>  
>  programs:	http://e2fsprogs.sourceforge.net/
>  
> -useful links:	http://fedoraproject.org/wiki/ext3-devel
> +useful links:	https://fedoraproject.org/wiki/ext3-devel
>  		http://www.bullopensource.org/ext4/

This link looks pretty obviously dead, you should just take it out while
you're in the neighborhood.

>  		http://ext4.wiki.kernel.org/index.php/Main_Page

And this one already redirects to https, is there a reason why you didn't
change it?

> index fb95fad81c79..b333ba5cb144 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -2786,7 +2786,7 @@
>  			touchscreen support is not enabled in the mainstream
>  			kernel as of 2.6.30, a preliminary port can be found
>  			in the "bleeding edge" mini2440 support kernel at
> -			http://repo.or.cz/w/linux-2.6/mini2440.git
> +			https://repo.or.cz/w/linux-2.6/mini2440.git

A repo that hasn't seen a commit since 2009 doesn't quite qualify as
"bleeding edge" IMO, but I guess we can let that one slide...:)


> index 874eb0c77d34..e87bf0135edf 100644
> --- a/Documentation/admin-guide/mm/ksm.rst
> +++ b/Documentation/admin-guide/mm/ksm.rst
> @@ -9,7 +9,7 @@ Overview
>  
>  KSM is a memory-saving de-duplication feature, enabled by CONFIG_KSM=y,
>  added to the Linux kernel in 2.6.32.  See ``mm/ksm.c`` for its implementation,
> -and http://lwn.net/Articles/306704/ and http://lwn.net/Articles/330589/
> +and http://lwn.net/Articles/306704/ and https://lwn.net/Articles/330589/

Why did you only change one of those?

Thanks,

jon