Re: [PATCH] staging: media: usbvision: removing prohibited space before ',' (ctx:WxW)

From: Hans Verkuil
Date: Sat Jun 27 2020 - 04:28:43 EST


On 27/06/2020 07:07, Greg Kroah-Hartman wrote:
>
> A: http://en.wikipedia.org/wiki/Top_post
> Q: Were do I find info about this thing called top-posting?
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
>
> A: No.
> Q: Should I include quotations after my reply?
>
> http://daringfireball.net/2007/07/on_top
>
> On Fri, Jun 26, 2020 at 11:42:49AM -0400, B K KARTHIK PES2201800185STUDENT ECE DeptPESU EC Campus wrote:
>> Oh, I'm sorry but wouldn't it be helpful if we had a file that lists
>> all drivers that are scheduled for removal?
>
> The TODO file in the directory for the driver should have this
> information in it. I don't know if all of the media drivers have this,
> if not, then there is no way you could have known this.

They have, and in addition the Kconfig entry will mention that the driver
is deprecated.

TODO of usbvision:

The driver is deprecated and scheduled for removal by the end
of 2020.

In order to prevent removal the following actions would have to
be taken:

- clean up the code
- convert to the vb2 framework
- fix the disconnect and free-on-last-user handling (i.e., add
a release callback for struct v4l2_device and rework the code
to use that correctly).

Regards,

Hans