Re: [PATCH v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error in ak8974_probe()
From: Jonathan Cameron
Date: Sat Jun 27 2020 - 10:53:17 EST
On Thu, 25 Jun 2020 14:34:44 +0200
Markus Elfring <Markus.Elfring@xxxxxx> wrote:
> https://lkml.org/lkml/2020/6/14/117
> https://lore.kernel.org/patchwork/comment/1452516/
> https://lore.kernel.org/linux-iio/20200614131116.143bcf92@archlinux/
>
> > There was a lot of fuzz in this one due to other changes to the driver.
> > I 'think' it went it cleanly though.
>
> Is it interesting anyhow that you committed a change description
> which contained typos (on 2020-06-14 13:08:47 +0100)?
> https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/drivers/iio/magnetometer/ak8974.c?h=fixes-togreg&id=0187294d227dfc42889e1da8f8ce1e44fc25f147
>
> How were the chances that my patch review comments would be taken
> better into account?
> https://lore.kernel.org/linux-iio/dd84c12f-277d-27e7-3727-4592e530e4ed@xxxxxx/
> https://lkml.org/lkml/2020/5/31/152
I'm not sure why, but your reply did not have a reply-to field in the header
as such my email client did not present it alongside the patch. Hence I
missed it when applying.
Agreed it would have been nicer to have fixed those typos.
However, they don't affect comprehensibility of the message so I'm not that
worried about having them in the log.
Jonathan
>
> Regards,
> Markus