Re: [PATCH v3 3/7] iio: core: remove padding from private information

From: Jonathan Cameron
Date: Sat Jun 27 2020 - 12:41:57 EST


On Sun, 21 Jun 2020 15:33:41 +0300
Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> wrote:

> There was a recent discussion about this code:
> https://lore.kernel.org/linux-iio/20200322165317.0b1f0674@archlinux/
>
> This looks like a good time to removed this, since any issues about it
> should pop-up under testing, because the iio_dev is having a bit of an
> overhaul and stuff being moved to iio_dev_opaque.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>
*crosses fingers*

Applied to the togreg branch of iio.git and pushed out as testing.

Jonathan

> ---
> drivers/iio/industrialio-core.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index 33e2953cf021..27005ba4d09c 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -1507,8 +1507,6 @@ struct iio_dev *iio_device_alloc(struct device *parent, int sizeof_priv)
> alloc_size = ALIGN(alloc_size, IIO_ALIGN);
> alloc_size += sizeof_priv;
> }
> - /* ensure 32-byte alignment of whole construct ? */
> - alloc_size += IIO_ALIGN - 1;
>
> iio_dev_opaque = kzalloc(alloc_size, GFP_KERNEL);
> if (!iio_dev_opaque)