Re: [PATCH 07/10] perf tools: Collect other metrics in struct metric_expr

From: Jiri Olsa
Date: Sun Jun 28 2020 - 17:55:25 EST


On Fri, Jun 26, 2020 at 02:10:57PM -0700, Ian Rogers wrote:
> On Fri, Jun 26, 2020 at 12:48 PM Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> >
> > Add 'other' metrics into struct metric_expr object,
> > so they are accessible when computing the metric.
> >
> > Storing just name and expression itself, so the metric
> > can be resolved and computed.
>
> Nit, other vs something like referenced_metric but otherwise lgtm.

I'd like to keep metric prefix

struct metric_ref ?

jirka