Re: [PATCH] fbtft-bus.c: Removing that prohibited space before ')'

From: kernel test robot
Date: Sun Jun 28 2020 - 20:30:53 EST

Next message: Dave Chinner: "Re: [PATCH 0/6] Overhaul memalloc_no*"
Previous message: Roy Im: "RE: [PATCH v14 3/3] Input: new da7280 haptic driver"
In reply to: kernel test robot: "Re: [PATCH] fbtft-bus.c: Removing that prohibited space before ')'"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi K,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v5.8-rc2 next-20200626]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/B-K-Karthik/fbtft-bus-c-Removing-that-prohibited-space-before/20200627-125315
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 92cd1b5d65f5c67147c7da39a3c2ad7e6ff81027
config: ia64-randconfig-s031-20200624 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-dirty
# save the attached .config to linux build tree
make W=1 C=1 ARCH=ia64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

sparse warnings: (new ones prefixed by >>)

>> drivers/staging/fbtft/fbtft-bus.c:65:1: sparse: sparse: macro "define_fbtft_write_reg" requires 4 arguments, but only 3 given
drivers/staging/fbtft/fbtft-bus.c:67:1: sparse: sparse: macro "define_fbtft_write_reg" requires 4 arguments, but only 3 given
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got void
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ) in function declarator
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got (
>> drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Trying to use reserved word 'if' as identifier
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ) in function declarator
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got =
>> drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Trying to use reserved word 'for' as identifier
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got <
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got ++
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got +=
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got }
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got +=
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got }
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got +=
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got }
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got +=
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got }
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got }
>> drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Trying to use reserved word 'do' as identifier
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got {
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got }
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got }
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ) in function declarator
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got ->
>> drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Trying to use reserved word 'if' as identifier
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got }
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got +=
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got }
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got +=
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got }
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got +=
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got }
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got +=
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got }
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ) in function declarator
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got <
>> drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Trying to use reserved word 'if' as identifier
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got --
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ) in function declarator
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got ->
>> drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Trying to use reserved word 'if' as identifier
>> drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Trying to use reserved word 'if' as identifier
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got :
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration
drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got }
drivers/staging/fbtft/fbtft-bus.c:69:1: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:69:1: sparse: sparse: got void
drivers/staging/fbtft/fbtft-bus.c:76:13: sparse: sparse: Expected ) in function declarator
drivers/staging/fbtft/fbtft-bus.c:76:13: sparse: sparse: got (
drivers/staging/fbtft/fbtft-bus.c:76:9: sparse: sparse: Trying to use reserved word 'if' as identifier
drivers/staging/fbtft/fbtft-bus.c:78:24: sparse: sparse: Expected ) in function declarator
drivers/staging/fbtft/fbtft-bus.c:78:24: sparse: sparse: got =
drivers/staging/fbtft/fbtft-bus.c:78:17: sparse: sparse: Trying to use reserved word 'for' as identifier
drivers/staging/fbtft/fbtft-bus.c:78:31: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:78:31: sparse: sparse: got <
drivers/staging/fbtft/fbtft-bus.c:78:39: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:78:39: sparse: sparse: got ++
drivers/staging/fbtft/fbtft-bus.c:79:50: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:79:50: sparse: sparse: got +=
drivers/staging/fbtft/fbtft-bus.c:79:50: sparse: sparse: Expected ; at the end of type declaration
drivers/staging/fbtft/fbtft-bus.c:79:50: sparse: sparse: got }
drivers/staging/fbtft/fbtft-bus.c:81:17: sparse: sparse: Trying to use reserved word 'do' as identifier
drivers/staging/fbtft/fbtft-bus.c:81:17: sparse: sparse: Expected ; at end of declaration
drivers/staging/fbtft/fbtft-bus.c:81:17: sparse: sparse: got {
drivers/staging/fbtft/fbtft-bus.c:81:17: sparse: sparse: Expected ; at the end of type declaration
drivers/staging/fbtft/fbtft-bus.c:81:17: sparse: sparse: got }
drivers/staging/fbtft/fbtft-bus.c:84:9: sparse: sparse: Expected ; at the end of type declaration
drivers/staging/fbtft/fbtft-bus.c:84:9: sparse: sparse: got }
drivers/staging/fbtft/fbtft-bus.c:88:16: sparse: sparse: Expected ) in function declarator
drivers/staging/fbtft/fbtft-bus.c:88:16: sparse: sparse: got ->
drivers/staging/fbtft/fbtft-bus.c:88:9: sparse: sparse: Trying to use reserved word 'if' as identifier
drivers/staging/fbtft/fbtft-bus.c:93:24: sparse: sparse: Expected ) in function declarator
drivers/staging/fbtft/fbtft-bus.c:93:24: sparse: sparse: got =
>> drivers/staging/fbtft/fbtft-bus.c:93:17: sparse: sparse: too many errors

# https://github.com/0day-ci/linux/commit/f9a954fc5ae43b8fb5195dbb7152976581d80a1a
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout f9a954fc5ae43b8fb5195dbb7152976581d80a1a
vim +/define_fbtft_write_reg +65 drivers/staging/fbtft/fbtft-bus.c

c296d5f9957c03 Thomas Petazzoni 2014-12-31 64
f9a954fc5ae43b B K Karthik 2020-06-27 @65 define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
8d8825b420ffb3 Alfonso Lima Astor 2017-10-17 @66 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
f9a954fc5ae43b B K Karthik 2020-06-27 67 define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
c296d5f9957c03 Thomas Petazzoni 2014-12-31 68
c296d5f9957c03 Thomas Petazzoni 2014-12-31 69 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
c296d5f9957c03 Thomas Petazzoni 2014-12-31 70 {
c296d5f9957c03 Thomas Petazzoni 2014-12-31 71 va_list args;
c296d5f9957c03 Thomas Petazzoni 2014-12-31 72 int i, ret;
c296d5f9957c03 Thomas Petazzoni 2014-12-31 73 int pad = 0;
c296d5f9957c03 Thomas Petazzoni 2014-12-31 74 u16 *buf = (u16 *)par->buf;
c296d5f9957c03 Thomas Petazzoni 2014-12-31 75
c296d5f9957c03 Thomas Petazzoni 2014-12-31 76 if (unlikely(par->debug & DEBUG_WRITE_REGISTER)) {
c296d5f9957c03 Thomas Petazzoni 2014-12-31 77 va_start(args, len);
c296d5f9957c03 Thomas Petazzoni 2014-12-31 78 for (i = 0; i < len; i++)
c296d5f9957c03 Thomas Petazzoni 2014-12-31 79 *(((u8 *)buf) + i) = (u8)va_arg(args, unsigned int);
c296d5f9957c03 Thomas Petazzoni 2014-12-31 80 va_end(args);
c296d5f9957c03 Thomas Petazzoni 2014-12-31 @81 fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par,
333c7b940526be Leonardo BrÃs 2018-08-07 82 par->info->device, u8, buf, len, "%s: ",
333c7b940526be Leonardo BrÃs 2018-08-07 83 __func__);
c296d5f9957c03 Thomas Petazzoni 2014-12-31 84 }
c296d5f9957c03 Thomas Petazzoni 2014-12-31 85 if (len <= 0)
c296d5f9957c03 Thomas Petazzoni 2014-12-31 86 return;
c296d5f9957c03 Thomas Petazzoni 2014-12-31 87
c296d5f9957c03 Thomas Petazzoni 2014-12-31 88 if (par->spi && (par->spi->bits_per_word == 8)) {
c296d5f9957c03 Thomas Petazzoni 2014-12-31 89 /* we're emulating 9-bit, pad start of buffer with no-ops
b2ac4a927034d0 Anson Jacob 2016-08-25 90 * (assuming here that zero is a no-op)
b2ac4a927034d0 Anson Jacob 2016-08-25 91 */
c296d5f9957c03 Thomas Petazzoni 2014-12-31 92 pad = (len % 4) ? 4 - (len % 4) : 0;
c296d5f9957c03 Thomas Petazzoni 2014-12-31 @93 for (i = 0; i < pad; i++)
c296d5f9957c03 Thomas Petazzoni 2014-12-31 94 *buf++ = 0x000;
c296d5f9957c03 Thomas Petazzoni 2014-12-31 95 }
c296d5f9957c03 Thomas Petazzoni 2014-12-31 96
c296d5f9957c03 Thomas Petazzoni 2014-12-31 97 va_start(args, len);
c296d5f9957c03 Thomas Petazzoni 2014-12-31 98 *buf++ = (u8)va_arg(args, unsigned int);
c296d5f9957c03 Thomas Petazzoni 2014-12-31 99 i = len - 1;
c296d5f9957c03 Thomas Petazzoni 2014-12-31 100 while (i--) {
c296d5f9957c03 Thomas Petazzoni 2014-12-31 101 *buf = (u8)va_arg(args, unsigned int);
c296d5f9957c03 Thomas Petazzoni 2014-12-31 102 *buf++ |= 0x100; /* dc=1 */
c296d5f9957c03 Thomas Petazzoni 2014-12-31 103 }
c296d5f9957c03 Thomas Petazzoni 2014-12-31 104 va_end(args);
c296d5f9957c03 Thomas Petazzoni 2014-12-31 105 ret = par->fbtftops.write(par, par->buf, (len + pad) * sizeof(u16));
c296d5f9957c03 Thomas Petazzoni 2014-12-31 106 if (ret < 0) {
c296d5f9957c03 Thomas Petazzoni 2014-12-31 107 dev_err(par->info->device,
aed1c72e447f0a Haneen Mohammed 2015-03-06 108 "write() failed and returned %d\n", ret);
c296d5f9957c03 Thomas Petazzoni 2014-12-31 109 return;
c296d5f9957c03 Thomas Petazzoni 2014-12-31 110 }
c296d5f9957c03 Thomas Petazzoni 2014-12-31 111 }
c296d5f9957c03 Thomas Petazzoni 2014-12-31 112 EXPORT_SYMBOL(fbtft_write_reg8_bus9);
c296d5f9957c03 Thomas Petazzoni 2014-12-31 113

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- kbuild@xxxxxxxxxxxx
To unsubscribe send an email to kbuild-leave@xxxxxxxxxxxx

Next message: Dave Chinner: "Re: [PATCH 0/6] Overhaul memalloc_no*"
Previous message: Roy Im: "RE: [PATCH v14 3/3] Input: new da7280 haptic driver"
In reply to: kernel test robot: "Re: [PATCH] fbtft-bus.c: Removing that prohibited space before ')'"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]