Re: [PATCH RFC] s390x/vmem: get rid of memory segment list
From: David Hildenbrand
Date: Mon Jun 29 2020 - 15:03:13 EST
On 29.06.20 13:55, Heiko Carstens wrote:
> On Fri, Jun 26, 2020 at 08:46:21PM +0200, Gerald Schaefer wrote:
>> Verified with DCSS overlapping boot and standby memory, works fine.
>> As expected, the error message changes, but I don't think that is a
>> problem, as long as you also remove the old -ENOSPC case / comment
>> in arch/s390/mm/extmem.c. It is actually more correct now I guess,
>> -ENOSPC doesn't look like the correct return value anyway.
>>
>> Thanks for cleaning up! Looks good to me, and removes > 100 LOC,
>> unless Heiko remembers some other issues from ancient times.
>>
>> Reviewed-by: Gerald Schaefer <gerald.schaefer@xxxxxxxxxx>
>> Tested-by: Gerald Schaefer <gerald.schaefer@xxxxxxxxxx> [DCSS]
>
> Looks good to me too. Gerald, thanks for looking and verifying this,
> and David, thanks for providing the patch.
>
> Applied.
>
Thanks Gerald and Heiko! Should I send an addon patch to tweak the
documentation or resend this patch?
--
Thanks,
David / dhildenb