RE: [PATCH 3/3] ARM: imx: Select RESET_IMX7 for i.MX7D

[Anson Huang]

Hi, Arnd


> Subject: Re: [PATCH 3/3] ARM: imx: Select RESET_IMX7 for i.MX7D
> 
> On Mon, Jun 29, 2020 at 1:36 PM Anson Huang <anson.huang@xxxxxxx>
> wrote:
> > > Subject: Re: [PATCH 3/3] ARM: imx: Select RESET_IMX7 for i.MX7D
> > >
> > > On Mon, Jun 29, 2020 at 12:25 PM Anson Huang
> <Anson.Huang@xxxxxxx>
> > > wrote:
> > > >
> > > > i.MX7 reset driver now supports module build, it is no longer
> > > > built in by default, need to select it explicitly for i.MX7D.
> > > >
> > > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> > > > ---
> > > >  arch/arm/mach-imx/Kconfig | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> > > > index e7d7b90..3540483 100644
> > > > --- a/arch/arm/mach-imx/Kconfig
> > > > +++ b/arch/arm/mach-imx/Kconfig
> > > > @@ -561,6 +561,7 @@ config SOC_IMX7D_CM4  config SOC_IMX7D
> > > >         bool "i.MX7 Dual support"
> > > >         select PINCTRL_IMX7D
> > > > +       select RESET_IMX7
> > >
> > > Please drop this patch, it breaks the intent of the first one by
> > > forcing the driver to be built-in again rather than a loadable module.
> > >
> >
> > One thing to clarify is, the loadable module support is ONLY for i.MX
> > ARMv8 SoCs,
> 
> I don't understand. Why can't this driver be a loadable module on i.MX7?
> Please clarify in the changelog what the bug is on i.MX7.
> 
> > ARMv7 SoCs is NOT in the plan, that is why I add this patch to make it
> > same as previously when this reset driver is =y by default. Without
> > this patch, this reset driver will NOT be enabled by default for i.MX ARMv7
> SoCs, function will be broken.
> 
> But it's the same driver, make it work the same way on all chips!
> 
> I think artificially limiting a new driver feature to one chip just because nobody
> asked for it on another chip is not helpful.
> 

Understood, what if I don't select it in SOC config which is NOT flexible, but put it in
imx_v6_v7_defconfig, then user can select either =y or =m according their requirement?
And in imx_v6_v7_defconfig make it =y by default.

Thanks,
Anson