Re: [PATCH -next] <linux/of.h>: add stub for of_get_next_parent() to fix qcom build error

From: Bjorn Andersson
Date: Mon Jun 29 2020 - 15:28:10 EST


On Mon 29 Jun 09:43 PDT 2020, Randy Dunlap wrote:

> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Fix a (COMPILE_TEST) build error when CONFIG_OF is not set/enabled
> by adding a stub for of_get_next_parent().
>
> ../drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function 'of_get_next_parent'; did you mean 'of_get_parent'? [-Werror=implicit-function-declaration]
> ../drivers/soc/qcom/qcom-geni-se.c:819:9: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Frank Rowand <frowand.list@xxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: Andy Gross <agross@xxxxxxxxxx>
> Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> Cc: linux-arm-msm@xxxxxxxxxxxxxxx

Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

Regards,
Bjorn

> ---
> include/linux/of.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> --- linux-next-20200629.orig/include/linux/of.h
> +++ linux-next-20200629/include/linux/of.h
> @@ -630,6 +630,11 @@ static inline struct device_node *of_get
> return NULL;
> }
>
> +static inline struct device_node *of_get_next_parent(struct device_node *node)
> +{
> + return NULL;
> +}
> +
> static inline struct device_node *of_get_next_child(
> const struct device_node *node, struct device_node *prev)
> {
>
>