Re: [PATCH v1 1/4] qlge/qlge_main.c: use genric power management

From: Vaibhav Gupta
Date: Mon Jun 29 2020 - 15:37:58 EST

On Mon, 29 Jun 2020 at 21:39, kernel test robot <lkp@xxxxxxxxx> wrote:
>
> Hi Vaibhav,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on v5.8-rc3 next-20200629]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Vaibhav-Gupta/drivers-staging-use-generic-power-management/20200629-163141
> base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 347fa58ff5558075eec98725029c443c80ffbf4a
> config: x86_64-rhel-7.6 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
> reproduce (this is a W=1 build):
> # save the attached .config to linux build tree
> make W=1 ARCH=x86_64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>
> All errors (new ones prefixed by >>):
>
> drivers/staging/qlge/qlge_main.c: In function 'qlge_resume':
> >> drivers/staging/qlge/qlge_main.c:4793:17: error: 'pdev' undeclared (first use in this function); did you mean 'qdev'?
> 4793 | pci_set_master(pdev);
> | ^~~~
> | qdev
> drivers/staging/qlge/qlge_main.c:4793:17: note: each undeclared identifier is reported only once for each function it appears in
>
> vim +4793 drivers/staging/qlge/qlge_main.c
>
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4786
> 1aed508211e137 drivers/staging/qlge/qlge_main.c Vaibhav Gupta 2020-06-29 4787 static int __maybe_unused qlge_resume(struct device *dev_d)
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4788 {
> 1aed508211e137 drivers/staging/qlge/qlge_main.c Vaibhav Gupta 2020-06-29 4789 struct net_device *ndev = dev_get_drvdata(dev_d);
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4790 struct ql_adapter *qdev = netdev_priv(ndev);
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4791 int err;
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4792
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 @4793 pci_set_master(pdev);
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4794
> 1aed508211e137 drivers/staging/qlge/qlge_main.c Vaibhav Gupta 2020-06-29 4795 device_wakeup_disable(dev_d);
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4796
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4797 if (netif_running(ndev)) {
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4798 err = ql_adapter_up(qdev);
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4799 if (err)
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4800 return err;
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4801 }
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4802
> 72046d84f0d6e3 drivers/net/qlge/qlge_main.c Breno Leitao 2010-07-01 4803 mod_timer(&qdev->timer, jiffies + (5 * HZ));
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4804 netif_device_attach(ndev);
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4805
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4806 return 0;
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4807 }
> c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4808
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
This is a genuine error. I remember taking care of it when I upgraded
the driver.
Must have been caused by some unnoticed reverts at my side.

I will fix it and send a v2 patch-set. Thanks for reporting.

-- Vaibhav gupta