Re: [PATCH v2 1/3] clk: JZ4780: Add functions for enable and disable USB PHY.
From: kernel test robot
Date: Mon Jun 29 2020 - 17:11:51 EST
Hi "åçæ,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on clk/clk-next]
[also build test ERROR on linux/master linus/master v5.8-rc3 next-20200629]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Zhou-Yanjie/Add-functions-to-operate-USB-PHY-related-clock/20200629-011858
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
In file included from arch/x86/include/asm/bug.h:86,
from include/linux/bug.h:5,
from include/linux/debug_locks.h:7,
from include/linux/lockdep.h:44,
from include/linux/spinlock_types.h:18,
from include/linux/mutex.h:16,
from include/linux/kernfs.h:12,
from include/linux/sysfs.h:16,
from include/linux/kobject.h:20,
from include/linux/of.h:17,
from include/linux/clk-provider.h:9,
from drivers/clk/ingenic/jz4780-cgu.c:10:
drivers/clk/ingenic/jz4780-cgu.c: In function 'jz4780_otg_phy_recalc_rate':
include/asm-generic/bug.h:127:34: error: expected expression before ')' token
127 | int __ret_warn_on = !!(condition); \
| ^
drivers/clk/ingenic/jz4780-cgu.c:129:2: note: in expansion of macro 'WARN'
129 | WARN();
| ^~~~
>> include/asm-generic/bug.h:96:3: error: too few arguments to function '__warn_printk'
96 | __warn_printk(arg); \
| ^~~~~~~~~~~~~
include/asm-generic/bug.h:129:3: note: in expansion of macro '__WARN_printf'
129 | __WARN_printf(TAINT_WARN, format); \
| ^~~~~~~~~~~~~
drivers/clk/ingenic/jz4780-cgu.c:129:2: note: in expansion of macro 'WARN'
129 | WARN();
| ^~~~
include/asm-generic/bug.h:92:28: note: declared here
92 | extern __printf(1, 2) void __warn_printk(const char *fmt, ...);
| ^~~~~~~~~~~~~
vim +/__warn_printk +96 include/asm-generic/bug.h
^1da177e4c3f41 Linus Torvalds 2005-04-16 64
af9379c7121d55 David Brownell 2009-01-06 65 /*
af9379c7121d55 David Brownell 2009-01-06 66 * WARN(), WARN_ON(), WARN_ON_ONCE, and so on can be used to report
96c6a32ccb55a3 Dmitry Vyukov 2018-08-21 67 * significant kernel issues that need prompt attention if they should ever
96c6a32ccb55a3 Dmitry Vyukov 2018-08-21 68 * appear at runtime.
96c6a32ccb55a3 Dmitry Vyukov 2018-08-21 69 *
96c6a32ccb55a3 Dmitry Vyukov 2018-08-21 70 * Do not use these macros when checking for invalid external inputs
96c6a32ccb55a3 Dmitry Vyukov 2018-08-21 71 * (e.g. invalid system call arguments, or invalid data coming from
96c6a32ccb55a3 Dmitry Vyukov 2018-08-21 72 * network/devices), and on transient conditions like ENOMEM or EAGAIN.
96c6a32ccb55a3 Dmitry Vyukov 2018-08-21 73 * These macros should be used for recoverable kernel issues only.
96c6a32ccb55a3 Dmitry Vyukov 2018-08-21 74 * For invalid external inputs, transient conditions, etc use
96c6a32ccb55a3 Dmitry Vyukov 2018-08-21 75 * pr_err[_once/_ratelimited]() followed by dump_stack(), if necessary.
96c6a32ccb55a3 Dmitry Vyukov 2018-08-21 76 * Do not include "BUG"/"WARNING" in format strings manually to make these
96c6a32ccb55a3 Dmitry Vyukov 2018-08-21 77 * conditions distinguishable from kernel issues.
96c6a32ccb55a3 Dmitry Vyukov 2018-08-21 78 *
96c6a32ccb55a3 Dmitry Vyukov 2018-08-21 79 * Use the versions with printk format strings to provide better diagnostics.
af9379c7121d55 David Brownell 2009-01-06 80 */
d4bce140b4e739 Kees Cook 2019-09-25 81 #ifndef __WARN_FLAGS
b9075fa968a0a4 Joe Perches 2011-10-31 82 extern __printf(4, 5)
ee8711336c5170 Kees Cook 2019-09-25 83 void warn_slowpath_fmt(const char *file, const int line, unsigned taint,
b9075fa968a0a4 Joe Perches 2011-10-31 84 const char *fmt, ...);
f2f84b05e02b77 Kees Cook 2019-09-25 85 #define __WARN() __WARN_printf(TAINT_WARN, NULL)
5916d5f9b33473 Thomas Gleixner 2020-03-13 86 #define __WARN_printf(taint, arg...) do { \
5916d5f9b33473 Thomas Gleixner 2020-03-13 87 instrumentation_begin(); \
5916d5f9b33473 Thomas Gleixner 2020-03-13 88 warn_slowpath_fmt(__FILE__, __LINE__, taint, arg); \
5916d5f9b33473 Thomas Gleixner 2020-03-13 89 instrumentation_end(); \
5916d5f9b33473 Thomas Gleixner 2020-03-13 90 } while (0)
a8f18b909c0a3f Arjan van de Ven 2008-07-25 91 #else
a7bed27af194aa Kees Cook 2017-11-17 92 extern __printf(1, 2) void __warn_printk(const char *fmt, ...);
a44f71a9ab99b5 Kees Cook 2019-09-25 93 #define __WARN() __WARN_FLAGS(BUGFLAG_TAINT(TAINT_WARN))
d4bce140b4e739 Kees Cook 2019-09-25 94 #define __WARN_printf(taint, arg...) do { \
5916d5f9b33473 Thomas Gleixner 2020-03-13 95 instrumentation_begin(); \
d4bce140b4e739 Kees Cook 2019-09-25 @96 __warn_printk(arg); \
a44f71a9ab99b5 Kees Cook 2019-09-25 97 __WARN_FLAGS(BUGFLAG_NO_CUT_HERE | BUGFLAG_TAINT(taint));\
5916d5f9b33473 Thomas Gleixner 2020-03-13 98 instrumentation_end(); \
6b15f678fb7d5e Drew Davenport 2019-07-16 99 } while (0)
2da1ead4d5f7fa Kees Cook 2019-09-25 100 #define WARN_ON_ONCE(condition) ({ \
2da1ead4d5f7fa Kees Cook 2019-09-25 101 int __ret_warn_on = !!(condition); \
2da1ead4d5f7fa Kees Cook 2019-09-25 102 if (unlikely(__ret_warn_on)) \
2da1ead4d5f7fa Kees Cook 2019-09-25 103 __WARN_FLAGS(BUGFLAG_ONCE | \
2da1ead4d5f7fa Kees Cook 2019-09-25 104 BUGFLAG_TAINT(TAINT_WARN)); \
2da1ead4d5f7fa Kees Cook 2019-09-25 105 unlikely(__ret_warn_on); \
2da1ead4d5f7fa Kees Cook 2019-09-25 106 })
3a6a62f96f168d Olof Johansson 2008-01-30 107 #endif
3a6a62f96f168d Olof Johansson 2008-01-30 108
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip