Re: [PATCH 2/2] usb: mtu3: fix NULL pointer dereference

From: Markus Elfring
Date: Mon Jun 29 2020 - 17:40:45 EST


> Some pointers are dereferenced before successful checks.

I suggest to reconsider and improve the change description.

* Would a null pointer dereference be possible only with the variables âmepâ
and âmreqâ in the implementation of the function âmtu3_gadget_dequeueâ?

* How do you think about to adjust any more variable initialisations?

* Will it become helpful to add the tag âFixesâ to the commit message?

Regards,
Markus