Re: [PATCH v2 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening

[Wei Liu]

On Mon, Jun 29, 2020 at 09:33:15PM +0000, Haiyang Zhang wrote:
> 
> 
> > -----Original Message-----
> > From: Andres Beltran <lkmlabelt@xxxxxxxxx>
> > Sent: Monday, June 29, 2020 4:02 PM
> > To: KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang Zhang
> > <haiyangz@xxxxxxxxxxxxx>; Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>;
> > wei.liu@xxxxxxxxxx
> > Cc: linux-hyperv@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Michael
> > Kelley <mikelley@xxxxxxxxxxxxx>; parri.andrea@xxxxxxxxx; Andres Beltran
> > <lkmlabelt@xxxxxxxxx>; David S . Miller <davem@xxxxxxxxxxxxx>; Jakub
> > Kicinski <kuba@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx
> > Subject: [PATCH v2 3/3] hv_netvsc: Use vmbus_requestor to generate
> > transaction IDs for VMBus hardening
> > 
> > Currently, pointers to guest memory are passed to Hyper-V as
> > transaction IDs in netvsc. In the face of errors or malicious
> > behavior in Hyper-V, netvsc should not expose or trust the transaction
> > IDs returned by Hyper-V to be valid guest memory addresses. Instead,
> > use small integers generated by vmbus_requestor as requests
> > (transaction) IDs.
> > 
> > Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> > Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> > Cc: netdev@xxxxxxxxxxxxxxx
> > Signed-off-by: Andres Beltran <lkmlabelt@xxxxxxxxx>
> 
> Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> 
> 

Thanks Haiyang for reviewing.

David and Jakub:

This patch depends on the first patch. I intend to pick up this patch
via hyperv.git. This makes life easier for all of us. Let me know if you
disagree.

Wei.