Re: linux-next: build failures after merge of the vfs tree

[Stephen Rothwell]

Hi all,

On Thu, 18 Jun 2020 10:08:51 +1000 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
> On Wed, 17 Jun 2020 17:38:45 +1000 Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Wed, Jun 17, 2020 at 05:31:02PM +1000, Stephen Rothwell wrote:  
> > > > > 
> > > > > Presumably another include needed:
> > > > > 
> > > > > arch/s390/lib/test_unwind.c:49:2: error: implicit declaration of function 'kmalloc' [-Werror=implicit-function-declaration]
> > > > > arch/s390/lib/test_unwind.c:99:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]      
> > > 
> > > And more (these are coming from other's builds):
> > > 
> > >   drivers/remoteproc/qcom_q6v5_mss.c:772:3: error: implicit declaration of function 'kfree' [-Werror,-Wimplicit-function-declaration]
> > >   drivers/remoteproc/qcom_q6v5_mss.c:808:2: error: implicit declaration of function 'kfree' [-Werror,-Wimplicit-function-declaration]
> > >   drivers/remoteproc/qcom_q6v5_mss.c:1195:2: error: implicit declaration of function 'kfree' [-Werror,-Wimplicit-function-declaration]
> > > 
> > > They may have other causes as they are full linux-next builds (not just
> > > after the merge of the vfs tree), but the timing is suspicious.    
> > 
> > OK, here's a patch for both of these together:
> > 
> > diff --git a/arch/s390/lib/test_unwind.c b/arch/s390/lib/test_unwind.c
> > index 32b7a30b2485..eb382ceaa116 100644
> > --- a/arch/s390/lib/test_unwind.c
> > +++ b/arch/s390/lib/test_unwind.c
> > @@ -9,6 +9,7 @@
> >  #include <linux/kallsyms.h>
> >  #include <linux/kthread.h>
> >  #include <linux/module.h>
> > +#include <linux/slab.h>
> >  #include <linux/string.h>
> >  #include <linux/kprobes.h>
> >  #include <linux/wait.h>
> > diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> > index feb70283b6a2..903b2bb97e12 100644
> > --- a/drivers/remoteproc/qcom_q6v5_mss.c
> > +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> > @@ -26,6 +26,7 @@
> >  #include <linux/reset.h>
> >  #include <linux/soc/qcom/mdt_loader.h>
> >  #include <linux/iopoll.h>
> > +#include <linux/slab.h>
> >  
> >  #include "remoteproc_internal.h"
> >  #include "qcom_common.h"  
> 
> I have applied those 2 by hand for today.

I am still applying the above patch.

-- 
Cheers,
Stephen Rothwell

Attachment: pgpToCOZKqP7N.pgp
Description: OpenPGP digital signature