Re: [PATCH] phy: qcom: remove ufs qmp phy driver

From: Vinod Koul
Date: Tue Jun 30 2020 - 00:54:33 EST


Hi Bjorn,

On 29-06-20, 12:24, Bjorn Andersson wrote:
> On Mon 29 Jun 07:54 PDT 2020, Vinod Koul wrote:
>
> > UFS QMP phy drivers are duplicate as we are supposed to use common QMP
> > phy driver which is working fine on various platforms. So remove the
> > unused driver
> >
>
> This describes the current state, but the UFS QMP driver had a purpose
> not that long ago and I would like the commit message to describe what
> changed and why it's now fine to remove the driver.

Would below look better, also feel free to suggest as you have the
more history on this :)

"UFS QMP driver is dedicated driver for QMP phy for UFS variant. We
also have a common QMP phy driver which works not only for UFS but
USB and PCIe as well, so retire this driver in favour of the common
driver"

>
> I'm happy with the patch itself (i.e. the removal of the driver) though.

Thanks
--
~Vinod