Re: [PATCH] SPI LPC information kernel module

From: Greg Kroah-Hartman
Date: Tue Jun 30 2020 - 05:01:03 EST


On Mon, Jun 29, 2020 at 07:59:32PM -0300, Daniel Gutson wrote:
> +EXPORT_SYMBOL_GPL(spi_read_sbase);

Why are you exporting symbols? Nothing in this patch uses them.

And that's the spi_* namespace for the SPI core, not your tiny driver,
why pollute the global namespace in a confusing way like this?

thanks,

greg k-h