Re: [PATCH v2] usb: mtu3: Fix NULL pointer dereferences

From: Markus Elfring
Date: Tue Jun 30 2020 - 06:47:23 EST


> Some pointers are dereferenced before successful checks.

I propose to reconsider and improve also this change description.

* Would a null pointer dereference be possible only with the variables âmepâ
and âmreqâ in the implementation of the function âmtu3_gadget_dequeueâ?
(Can it make sense to split the patch according to this detail?)

* How do you think about to convert any more variable initialisations
to later assignments?

* Will it become helpful to add the tag âFixesâ to the commit message?


â
> ---
> v2: nothing changed, but abandon another patch

Are there chances to take any previous patch review comments better into account
(besides the shown reduction of update steps)?


> ---
> drivers/usb/mtu3/mtu3_gadget.c | 25 ++++++++++++++++++-------

I suggest to replace the triple dashes before this diffstat by a blank line.

Regards,
Markus