RE: [PATCH v4 3/5] scsi: ufs: Introduce HPB module

[Avri Altman]

> +static int ufshpb_get_dev_info(struct ufs_hba *hba,
> +                              struct ufshpb_dev_info *hpb_dev_info,
> +                              u8 *desc_buf)
> +{
> +       int ret;
> +       int version;
> +       u8 hpb_mode;
Maybe before doing anything, first verify that all descriptors are in the proper size?

> +#define UFSHPB_WRITE_BUFFER_ID                 0x02
Should be 0x01 for HPB1.0

Thanks,
Avri