Re: [PATCH 04/10] gpio: gpio-pmic-eic-sprd: Fix incorrectly named property 'map'

[Baolin Wang]

On Tue, Jun 30, 2020 at 9:33 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> A good attempt has been made to properly document 'struct
> sprd_pmic_eic', but 'map' has been incorrectly described as
> 'regmap' since the driver's inception in 2018.
>
> Fixes the following W=1 kernel build warning:
>
>  drivers/gpio/gpio-pmic-eic-sprd.c:65: warning: Function parameter or member 'map' not described in 'sprd_pmic_eic'
>
> Cc: Orson Zhai <orsonzhai@xxxxxxxxx>
> Cc: Baolin Wang <baolin.wang7@xxxxxxxxx>
> Cc: Chunyan Zhang <zhang.lyra@xxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Looks good to me.
Reviewed-by: Baolin Wang <baolin.wang7@xxxxxxxxx>

> ---
>  drivers/gpio/gpio-pmic-eic-sprd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c
> index 05000cace9b24..9382851905662 100644
> --- a/drivers/gpio/gpio-pmic-eic-sprd.c
> +++ b/drivers/gpio/gpio-pmic-eic-sprd.c
> @@ -48,7 +48,7 @@ enum {
>   * struct sprd_pmic_eic - PMIC EIC controller
>   * @chip: the gpio_chip structure.
>   * @intc: the irq_chip structure.
> - * @regmap: the regmap from the parent device.
> + * @map:  the regmap from the parent device.
>   * @offset: the EIC controller's offset address of the PMIC.
>   * @reg: the array to cache the EIC registers.
>   * @buslock: for bus lock/sync and unlock.
> --
> 2.25.1
>


-- 
Baolin Wang