Re: [PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

[Andrzej Hajda]

On 30.06.2020 10:59, Grygorii Strashko wrote:
> Hi
>
> On 29/06/2020 14:28, Andrzej Hajda wrote:
>> Hi Grygorii,
>>
>> (...)
>>
>>>> ÂÂ /*
>>>> ÂÂÂ * deferred_devs_show() - Show the devices in the deferred probe
>>>> pending list.
>>>> ÂÂÂ */
>>>> @@ -221,7 +241,8 @@ static int deferred_devs_show(struct seq_file *s,
>>>> void *data)
>>>> ÂÂÂÂÂÂ mutex_lock(&deferred_probe_mutex);
>>>> ÂÂ ÂÂÂÂÂ list_for_each_entry(curr, &deferred_probe_pending_list,
>>>> deferred_probe)
>>>> -ÂÂÂÂÂÂÂ seq_printf(s, "%s\n", dev_name(curr->device));
>>>> +ÂÂÂÂÂÂÂ seq_printf(s, "%s\t%s", dev_name(curr->device),
>>>> + curr->device->p->deferred_probe_reason ?: "\n");
>>>> ÂÂ ÂÂÂÂÂ mutex_unlock(&deferred_probe_mutex);
>>>>
>>>
>>> Sry, may be i missing smth, but shouldn't it be optional
>>> (CONFIG_DEBUG_FS is probably too generic).
>>>
>>
>> I am not sure what exactly are you referring to, but this patch does not
>> add new property, it just extends functionality of existing one.
>
> Sry, needed to be more specific.
>
> You've added device_set_deferred_probe_reson(dev, &vaf);
> which expected to be used on every EPROBE_DEFER in dev_err_probe() in 
> combination with
>
> +ÂÂÂÂÂÂ } else {
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ device_set_deferred_probe_reson(dev, &vaf);
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ dev_dbg(dev, "error %d: %pV", err, &vaf);
>
> ^^ dev_dbg() does not add any runtime overhead during boot unless enabled
> +ÂÂÂÂÂÂ }
>
> But:
>
> +void device_set_deferred_probe_reson(const struct device *dev, struct 
> va_format *vaf)
> +{
> +ÂÂÂÂÂÂ const char *drv = dev_driver_string(dev);
> +
> +ÂÂÂÂÂÂ mutex_lock(&deferred_probe_mutex);
> +
> +ÂÂÂÂÂÂ kfree(dev->p->deferred_probe_reason);
> +ÂÂÂÂÂÂ dev->p->deferred_probe_reason = kasprintf(GFP_KERNEL, "%s: 
> %pV", drv, vaf);
> +
> +ÂÂÂÂÂÂ mutex_unlock(&deferred_probe_mutex);
> +}
>
> ^^ Adds locking, kfree() and kasprintf() for every deferred probe 
> during boot and can't be disabled.
>
> Right?


Right, but usually the burden should be insignificant in comparison to 
probe time, so I do not think it is worth optimizing.


Regards

Andrzej


>
>