Re: [RFC PATCH v2 00/18] Support for Tegra video capture from external sensor

[Sowjanya Komatineni]

On 6/30/20 9:17 AM, Sowjanya Komatineni wrote:
> On 6/30/20 8:44 AM, Sowjanya Komatineni wrote:
> > On 6/30/20 8:13 AM, Hans Verkuil wrote:
> > > On 30/06/2020 16:58, Sowjanya Komatineni wrote:
> > > > On 6/30/20 2:21 AM, Hans Verkuil wrote:
> > > > > On 17/06/2020 03:41, Sowjanya Komatineni wrote:
> > > > > > This series adds support for video capture from external camera 
> > > > > > sensor to
> > > > > > Tegra video driver.
> > > > > >
> > > > > > Jetson TX1 has camera expansion connector and supports custom 
> > > > > > camera module
> > > > > > designed as per TX1 design specification.
> > > > > >
> > > > > > This series also enables camera capture support for Jetson Nano 
> > > > > > which has
> > > > > > Raspberry PI camera header.
> > > > > >
> > > > > > This series is tested with IMX219 camera sensor.
> > > > > Which tree did you base this on? The media_tree master? Or the 
> > > > > mainline kernel?
> > > > These patches are with linux-next base at the time I sent them out 
> > > > which
> > > > are on 20200616
> > > > > I now have the imx219 detected, but if I try to stream I get this:
> > > > >
> > > > > $ v4l2-ctl --stream-mmap
> > > > > <[Â 512.840944] video4linux video0: MW_ACK_DONE syncpt timeout: -11
> > > > > [Â 512.972975] video4linux video0: frame start syncpt timeout: -11
> > > > > <VIDIOC_DQBUF: failed: Input/output error
> > > > > [Â 513.180770] video4linux video0: MW_ACK_DONE syncpt timeout: -11
> > > > >
> > > > > And then everything hangs and I need to reset.
> > > > >
> > > > > I'm testing with the media_tree master with your patches on top.
> > > > >
> > > > > Regards,
> > > > >
> > > > > ÂÂÂÂHans
> > > > Are you using same device tree as I sent offline? It uses CSI A for 
> > > > IMX219.
> > > >
> > > > Does you setup also uses CSI-A as x2 for IMX219?
> > > >
> > > > I tested them on Jetson Nano + IMX219 rasp PI module and also on 
> > > > Jetson
> > > > TX1 + IMX274.
> > > >
> > > > I did not see any issue and am able to capture from both.
> > > >
> > > > Will try again on my side with today's latest linux-next and update 
> > > > result.
> > > Please use the media_tree master, that's what I use as well.
> > >
> > > I did some more testing and there is something weird going on.
> > >
> > > I have a Leopard Imaging camera expansion board (LI-JTX1-MIPI-ADPT) 
> > > with
> > > three camera connectors. See here for the datasheet:
> > >
> > > https://www.leopardimaging.com/uploads/LI-TX1-KIT-IMX274M12-T_datasheet.pdf 
> > >
> > >
> > > The first connector (with an IMX274) causes this error:
> > >
> > > $ v4l2-ctl -d1 --stream-mmap
> > > [Â 599.265885] video4linux video1: MW_ACK_DONE syncpt timeout: -11
> > > [Â 599.473883] video4linux video1: MW_ACK_DONE syncpt timeout: -11
> > > [Â 599.681904] video4linux video1: frame start syncpt timeout: -11
> > > [Â 599.681909] video4linux video1: MW_ACK_DONE syncpt timeout: -11
> > > <VIDIOC_DQBUF: failed: Input/output error
> > > [Â 599.897884] video4linux video1: MW_ACK_DONE syncpt timeout: -11
> > >
> > > Similar to the test above where I had an IMX219 connected. Except it 
> > > didn't
> > > hang with the IMX274 (I'm beginning to suspect a locking issue in 
> > > the imx219
> > > driver that is causing the hang, I'll look at that tomorrow).
> > >
> > > If I connect the IMX219 to the middle camera connector, then it 
> > > works fine.
> > > I think I tested this with the IMX274 as well, but I'm not 100% 
> > > certain, also
> > > something to double check tomorrow.
> > >
> > > If I connect the IMX219 or IMX274 to the third camera connector, 
> > > then I get this:
> >
> > Would like to know CSI port mapping to connectors as mipi calibrate 
> > pads cells need to be updated in device tree based on CSI port in use.
> >
> > Will see if I can find that from DS link you sent above.
> >
> > > $ v4l2-ctl -d0 --stream-mmap
> > > [Â 820.513866] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > >
> > > [Â 820.525354] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > >
> > > [Â 820.536780] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > >
> > > [Â 820.548222] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > >
> > > [Â 820.559639] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > > <[Â 820.646931] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > > [Â 820.658355] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > > [Â 820.669797] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > > [Â 820.681216] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > > [Â 820.692601] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > > <<<<<<<<<<<<<<< 14.50 fps
> > > <<<<<<<<<<<<<<< 14.75 fps
> > > <<<<<<<<<<<<<<< 14.73 fps
> > > <<<<<<<<<<<<<<< 14.80 fps
> > > <<<<<<<<<<<<<[ 825.517854] tegra_mc_irq: 133437 callbacks suppressed
> > > [Â 825.517874] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > > [Â 825.534395] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > > [Â 825.545833] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > > [Â 825.557280] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > > [Â 825.579346] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > > [Â 825.590764] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > > [Â 825.602188] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > > [Â 825.613649] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > > [Â 825.625075] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > > [Â 825.645983] tegra-mc 70019000.memory-controller: viw: write 
> > > @0x00000001b5fd08c0: EMEM address decode error (EMEM decode error)
> > > < 14.64 fps
> > > <<<<<<<<<<<<<<<< 14.87 fps
> > > <<<<<<<<<<<<<<< 14.89 fps
> > >
> > > Something is producing EMEM address decode errors. But it is streaming.
> >
> > above memory controller errors may be due to access faults and not 
> > sure why these show up on your setup. I never have these with my 
> > testing.
> >
> > Also I am using CMA alloc of 256MB and not sure if low CMA alloc size 
> > is causing this. Can you try with CMA alloc size of 256MB?
> >
> > > If I enable the TPG then everything is fine.
> > >
> > > So I have currently three different behaviors for three camera 
> > > connectors.
> > >
> > > Do you have a datasheet for your Jetson TX1 camera board? It could 
> > > be useful
> > > to compare the two.
> >
> > Yeah we have and will send it offline.
> >
> > Also based on connector mapping to corresponding CSI port, 
> > mipi-calibrate pad cell value also need to be changed.
> >
> > Below is for CSI-A
> >
> > nvidia,mipi-calibrate = <&mipi 0x001>
> > > Regards,
> > >
> > > ÂÂÂÂHans
> Connector-1 is CSI-AB where you had timeouts.
>
> Connector-2 is CSI-CD and this works for you.
>
> Connector-3 is CSI-EF and this works for streaming from above but 
> there's memory access fault errors (EMEM address decode errors)
>
> These EMEM decode errors are not related to connector but its just 
> they showed up during connector-3 testing I believe. Can you also keep 
> CMA size to 256MB and try?
>
> Not sure if CSI-AB issue with FS and MW_ACK sp timeouts are due to 
> some HW/setup issue. Streaming should work on CSI-AB ports as well 
> just like CSI-CD/EF with proper device tree change for port index and 
> mipi calibrate cells for corresponding ports.
>
> On my setup that I tested IMX274 is on CSI-AB.
>
> Will update my side test results with today's linux-next

Hans,

We have this module as well. Will try to get this today for testing and 
will update just to make sure of this combo as well on my side.

https://www.leopardimaging.com/uploads/LI-TX1-KIT-IMX274M12-T_datasheet.pdf

Thanks

Sowjanya

> > > > > > This series include,
> > > > > >
> > > > > > VI I2C related fixes
> > > > > > - Camera sensor programming happens through VI I2C which is on 
> > > > > > host1x bus.
> > > > > > - These patches includes device tree and I2C driver fixes for VI 
> > > > > > I2C.
> > > > > >
> > > > > > Tegra video driver updates
> > > > > > - TPG Vs Non-TPG based on Kconfig
> > > > > > - Support for external sensor video capture based on device graph 
> > > > > > from DT.
> > > > > > - Support for selection ioctl operations
> > > > > > - Tegra MIPI CSI pads calibration
> > > > > > - CSI T-CLK and T-HS settle time computation based on clock rates.
> > > > > >
> > > > > > Host1x driver updates
> > > > > > - Adds API to allow creating mipi device for specific device node.
> > > > > > - Splits MIPI pads calibrate start and waiting for calibration to 
> > > > > > be done.
> > > > > >
> > > > > > Device tree updates
> > > > > > - Adds camera connector 2V8, 1V8, 1V2 regulator supplies to 
> > > > > > Jetson TX1 DT.
> > > > > > - Enabled VI and CSI support in Jetson Nano DT.
> > > > > >
> > > > > >
> > > > > > Delta between patch versions:
> > > > > >
> > > > > > [v2]:ÂÂÂ Includes below changes based on v1 feedback
> > > > > > ÂÂÂÂ- dt-binding document and the driver update for device graph 
> > > > > > to use
> > > > > > ÂÂÂÂÂ separate ports for sink endpoint and source endpoint for csi.
> > > > > > ÂÂÂÂ- Use data-lanes endpoint property for csi.
> > > > > > ÂÂÂÂ- Update tegra_mipi_request() to take device node pointer 
> > > > > > argument
> > > > > > ÂÂÂÂÂ rather than adding extra API.
> > > > > > ÂÂÂÂ- Remove checking for clk pointer before clk_disable.
> > > > > >
> > > > > >
> > > > > > Sowjanya Komatineni (18):
> > > > > > ÂÂÂ dt-bindings: i2c: tegra: Document Tegra210 VI I2C clocks and
> > > > > > ÂÂÂÂÂ power-domains
> > > > > > ÂÂÂ arm64: tegra: Add missing clocks and power-domains to 
> > > > > > Tegra210 VI I2C
> > > > > > ÂÂÂ i2c: tegra: Don't mark VI I2C as IRQ safe runtime PM
> > > > > > ÂÂÂ i2c: tegra: Fix the error path in tegra_i2c_runtime_resume
> > > > > > ÂÂÂ i2c: tegra: Fix runtime resume to re-init VI I2C
> > > > > > ÂÂÂ i2c: tegra: Avoid tegra_i2c_init_dma() for Tegra210 vi i2c
> > > > > > ÂÂÂ media: tegra-video: Fix channel format alignment
> > > > > > ÂÂÂ media: tegra-video: Enable TPG based on kernel config
> > > > > > ÂÂÂ media: tegra-video: Update format lookup to offset based
> > > > > > ÂÂÂ dt-bindings: tegra: Update VI and CSI bindings with port info
> > > > > > ÂÂÂ media: tegra-video: Add support for external sensor capture
> > > > > > ÂÂÂ media: tegra-video: Add support for selection ioctl ops
> > > > > > ÂÂÂ gpu: host1x: mipi: Update tegra_mipi_request() to be node based
> > > > > > ÂÂÂ gpu: host1x: mipi: Split tegra_mipi_calibrate and 
> > > > > > tegra_mipi_wait
> > > > > > ÂÂÂ media: tegra-video: Add CSI MIPI pads calibration
> > > > > > ÂÂÂ media: tegra-video: Compute settle times based on the clock rate
> > > > > > ÂÂÂ arm64: tegra: jetson-tx1: Add camera supplies
> > > > > > ÂÂÂ arm64: tegra: Enable Tegra VI CSI support for Jetson Nano
> > > > > >
> > > > > > ÂÂ .../display/tegra/nvidia,tegra20-host1x.txtÂÂÂÂÂÂÂ | 92 ++-
> > > > > > ÂÂ .../devicetree/bindings/i2c/nvidia,tegra20-i2c.txt | 19 +-
> > > > > > ÂÂ arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsiÂÂÂÂ | 41 ++
> > > > > > ÂÂ arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts | 10 +
> > > > > > ÂÂ arch/arm64/boot/dts/nvidia/tegra210.dtsiÂÂÂÂÂÂÂÂÂÂ | 6 +
> > > > > > ÂÂ drivers/gpu/drm/tegra/dsi.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 9 +-
> > > > > > ÂÂ drivers/gpu/host1x/mipi.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 30 +-
> > > > > > ÂÂ drivers/i2c/busses/i2c-tegra.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 39 +-
> > > > > > ÂÂ drivers/staging/media/tegra-video/KconfigÂÂÂÂÂÂÂÂÂ | 7 +
> > > > > > ÂÂ drivers/staging/media/tegra-video/csi.cÂÂÂÂÂÂÂÂÂÂÂ | 245 ++++++-
> > > > > > ÂÂ drivers/staging/media/tegra-video/csi.hÂÂÂÂÂÂÂÂÂÂÂ | 8 +
> > > > > > ÂÂ drivers/staging/media/tegra-video/tegra210.cÂÂÂÂÂÂ | 25 +-
> > > > > > ÂÂ drivers/staging/media/tegra-video/vi.cÂÂÂÂÂÂÂÂÂÂÂÂ | 770 
> > > > > > +++++++++++++++++++--
> > > > > > ÂÂ drivers/staging/media/tegra-video/vi.hÂÂÂÂÂÂÂÂÂÂÂÂ | 23 +-
> > > > > > ÂÂ drivers/staging/media/tegra-video/video.cÂÂÂÂÂÂÂÂÂ | 23 +-
> > > > > > ÂÂ include/linux/host1x.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 4 +-
> > > > > > ÂÂ 16 files changed, 1251 insertions(+), 100 deletions(-)