Re: [PATCH v2 26/30] misc: eeprom: at24: Tell the compiler that ACPI functions may not be used

From: Wolfram Sang
Date: Wed Jul 01 2020 - 04:48:32 EST


On Wed, Jul 01, 2020 at 09:31:14AM +0100, Lee Jones wrote:
> ... as is the case when !CONFIG_ACPI.
>
> Fixes the following W=1 kernel build warning:
>
> drivers/misc/eeprom/at24.c:228:36: warning: âat24_acpi_idsâ defined but not used [-Wunused-const-variable=]
>
> Cc: Wolfram Sang <wsa@xxxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Please CC the maintainer (Bartosz Golaszewski
<bgolaszewski@xxxxxxxxxxxx>) and the I2C list. get_maintainer.pl will
help you doing that automatically. Please also mention if this is
planned to go in via a specific tree and want acks or if you want the
patches to be picked up individually.

> ---
> drivers/misc/eeprom/at24.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
> index 9ff18d4961ceb..2591c21b2b5d8 100644
> --- a/drivers/misc/eeprom/at24.c
> +++ b/drivers/misc/eeprom/at24.c
> @@ -225,7 +225,7 @@ static const struct of_device_id at24_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, at24_of_match);
>
> -static const struct acpi_device_id at24_acpi_ids[] = {
> +static const struct acpi_device_id __maybe_unused at24_acpi_ids[] = {
> { "INT3499", (kernel_ulong_t)&at24_data_INT3499 },
> { "TPF0001", (kernel_ulong_t)&at24_data_24c1024 },
> { /* END OF LIST */ }
> --
> 2.25.1
>

Attachment: signature.asc
Description: PGP signature