Re: [PATCH v4 02/14] irqchip/csky-apb-intc: Fix potential resource leaks

[Markus Elfring]

> If remove the local variable "ret", it will look like this:
â
> +++ b/drivers/irqchip/irq-csky-apb-intc.c
â
> @@ -118,18 +116,23 @@ ck_intc_init_comm(struct device_node *node, struct device_node *parent)
â
> -ÂÂÂÂÂÂ ret = irq_alloc_domain_generic_chips(root_domain, 32, 1,
> +ÂÂÂÂÂÂ if (irq_alloc_domain_generic_chips(root_domain, 32, 1,
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ "csky_intc", handle_level_irq,
> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN, 0, 0);
> -ÂÂÂÂÂÂ if (ret) {
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN, 0, 0)) {
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pr_err("C-SKY Intc irq_alloc_gc failed.\n");
â

I suggest to recheck the parameter alignment for such a function call.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=7c30b859a947535f2213277e827d7ac7dcff9c84#n93

Regards,
Markus