Re: [v2] Documentation: Coccinelle: fix typos and command example

From: Randy Dunlap
Date: Wed Jul 01 2020 - 10:53:15 EST


On 7/1/20 6:32 AM, Markus Elfring wrote:
>>>>> We might stumble on different interpretations according to the wording âfile basisâ.
>>>>> Do you find a message like âmake: Nothing to be done for 'path/to/file.c'.â interesting then?
>>>>>
>>>>> * Would you like to add any links for information around the support for
>>>>> source code checkers?
>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Makefile?id=7c30b859a947535f2213277e827d7ac7dcff9c84#n198
>>> â
>>>> Feel free to submit patches.
>>>
>>> How do you think about to use the following command variant
>>> for the adjustment of the software documentation?
>>>
>>> + make C=1 CHECK='scripts/coccicheck' 'path/to/file.o'
>>
>> I don't understand the reason for that change...

IOW, your "patch" needs justification and/or explanation. It was missing that info.

> Is our understanding still incomplete for the support of source code checking parameters
> by the make script?
>
> * Will software analysis be performed in addition to the desired compilation
> of a source file (according to the selected object file)?
>
> * How do you think about to trigger only the generation of analysis results
> for a single file?

Do I need to remove that line from the patch?

Feel free to submit patches, not just comments.

--
~Randy