Re: [PATCH 16/20] block: move ->make_request_fn to struct block_device_operations

From: Dan Williams
Date: Wed Jul 01 2020 - 12:08:31 EST


On Wed, Jul 1, 2020 at 2:01 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> The make_request_fn is a little weird in that it sits directly in
> struct request_queue instead of an operation vector. Replace it with
> a block_device_operations method called submit_bio (which describes much
> better what it does). Also remove the request_queue argument to it, as
> the queue can be derived pretty trivially from the bio.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
[..]
> drivers/nvdimm/blk.c | 5 +-
> drivers/nvdimm/btt.c | 5 +-
> drivers/nvdimm/pmem.c | 5 +-

For drivers/nvdimm

Acked-by: Dan Williams <dan.j.williams@xxxxxxxxx>