RE: [Intel-wired-lan] [PATCH v1 1/5] iavf: use generic power management
From: Bowers, AndrewX
Date: Wed Jul 01 2020 - 13:05:48 EST
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of
> Vaibhav Gupta
> Sent: Monday, June 29, 2020 2:30 AM
> To: Bjorn Helgaas <helgaas@xxxxxxxxxx>; Bjorn Helgaas
> <bhelgaas@xxxxxxxxxx>; bjorn@xxxxxxxxxxx; Vaibhav Gupta
> <vaibhav.varodek@xxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>;
> Jakub Kicinski <kuba@xxxxxxxxxx>; Kirsher, Jeffrey T
> <jeffrey.t.kirsher@xxxxxxxxx>
> Cc: Vaibhav Gupta <vaibhavgupta40@xxxxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx;
> skhan@xxxxxxxxxxxxxxxxxxx; linux-kernel-
> mentees@xxxxxxxxxxxxxxxxxxxxxxxxx
> Subject: [Intel-wired-lan] [PATCH v1 1/5] iavf: use generic power
> management
>
> With the support of generic PM callbacks, drivers no longer need to use
> legacy .suspend() and .resume() in which they had to maintain PCI states
> changes and device's power state themselves. The required operations are
> done by PCI core.
>
> PCI drivers are not expected to invoke PCI helper functions like
> pci_save/restore_state(), pci_enable/disable_device(),
> pci_set_power_state(), etc. Their tasks are completed by PCI core itself.
>
> Compile-tested only.
>
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@xxxxxxxxx>
> ---
> drivers/net/ethernet/intel/iavf/iavf_main.c | 45 ++++++---------------
> 1 file changed, 12 insertions(+), 33 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers@xxxxxxxxx>