Re: [PATCH net-next 2/4] net: macb: use hweight_long() to count set bits in queue_mask

From: David Miller
Date: Wed Jul 01 2020 - 15:22:45 EST


From: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
Date: Wed, 1 Jul 2020 16:08:49 +0300

> @@ -3482,8 +3482,6 @@ static void macb_probe_queues(void __iomem *mem,
> unsigned int *queue_mask,
...
> + *num_queues = hweight_long(*queue_mask);

queue_mask is not a long, it is an unsinged int, therefore hweight32() is
probably more appropriate.