Re: [PATCH v9 00/11] Genericize DW MIPI DSI bridge and add i.MX 6 driver

From: Adrian Ratiu
Date: Wed Jul 01 2020 - 16:30:59 EST


Hi Heiko,

On Wed, 01 Jul 2020, Heiko StÃbner <heiko@xxxxxxxxx> wrote:
Hi Adrian,
Am Dienstag, 9. Juni 2020, 19:49:48 CEST schrieb Adrian Ratiu:
[Re-submitting to cc dri-devel, sorry about the noise] Hello all, v9 cleanly applies on top of latest next-20200609 tree.

at least it doesn't apply on top of current drm-misc-next for me which I really don't understand.
Like patch 2/11 does
@@ -31,6 +31,7 @@ #include <drm/drm_probe_helper.h> . #define HWVER_131<----><------><------>0x31333100<---->/* IP version 1.31 */ +#define HWVER_130<----><------><------>0x31333000<---->/* IP version 1.30 */ . #define DSI_VERSION<--><------><------>0x00 #define VERSION<------><------><------><------>GENMASK(31, 8)
where the file currently looks like
#include <drm/drm_atomic_helper.h> #include <drm/drm_bridge.h> #include <drm/drm_crtc.h> #include <drm/drm_mipi_dsi.h> #include <drm/drm_modes.h> #include <drm/drm_of.h> #include <drm/drm_print.h>
#define HWVER_131 0x31333100 /* IP version 1.31 */
#define DSI_VERSION 0x00 #define VERSION GENMASK(31, 8) even in Linux-next So I guess ideally rebase on top of drm-misc-next

I will send a rebase on top of drm-misc-next soon (with the last DTS nitpick fixed and the latest acks and reviewed-by tags added).

In the meantime I also found someone within Collabora who has a RK with a DSI panel and found a bug (likely clock is not enabled early enough to access the cfg registers to get the version for regmap).

I'm super happy this is getting tested on RK, thank you!



Thanks
Heiko