Re: objtool clac/stac handling change..

From: Andy Lutomirski
Date: Wed Jul 01 2020 - 23:08:41 EST



> On Jul 1, 2020, at 7:30 PM, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> ïOn Wed, Jul 1, 2020 at 5:48 PM Andy Lutomirski <luto@xxxxxxxxxx> wrote:
>>
>> You inspired me to mock it up.
>
> Ahh, you want to just use the jump folding of gcc to avoid the problem.
>
> I guess we could do that. Are there cases where this actually helps?
>

I was thinking it would help avoid brain melt. For better or for worse, the kernel is written in C, and readers donât really expect call_some_function(arg, other arg) to actually teleport elsewhere in the function. Iâm all for goto err; but at least thatâs spelled âgotoâ and itâs really obvious what it does.