Re: [v2] Documentation: Coccinelle: fix typos and command example

From: Julia Lawall
Date: Thu Jul 02 2020 - 01:40:27 EST




On Thu, 2 Jul 2020, Matthew Wilcox wrote:

> On Wed, Jul 01, 2020 at 07:52:58AM -0700, Randy Dunlap wrote:
> > On 7/1/20 6:32 AM, Markus Elfring wrote:
> > >>> How do you think about to use the following command variant
> > >>> for the adjustment of the software documentation?
> > >>>
> > >>> + make C=1 CHECK='scripts/coccicheck' 'path/to/file.o'
> > >>
> > >> I don't understand the reason for that change...
> >
> > IOW, your "patch" needs justification and/or explanation. It was missing that info.
>
> What Markus is trying so completely ineptly to say is that
> make C=1 CHECK=scripts/coccicheck path/to/file.c
> doesn't work. You need to use the .o suffix to check the .c file.

Thanks Matthew for this very helpful information.

julia