Re: [PATCH v3] i2c: designware: platdrv: Set class based on dmi

[Andy Shevchenko]

On Thu, Jul 02, 2020 at 11:38:32AM +0200, Ricardo Ribalda wrote:
> Current AMD's zen-based APUs use this core for some of its i2c-buses.
> 
> With this patch we re-enable autodetection of hwmon-alike devices, so
> lm-sensors will be able to work automatically.
> 
> It does not affect the boot-time of embedded devices, as the class is
> set based on the dmi information.

dmi -> DMI

> Dmi is probed only on Qtechnology QT5222 Industrial Camera Platform

Dmi -> DMI

> https://qtec.com/camera-technology-camera-platforms/

Use DocLink: tag.

...

> +static const struct dmi_system_id allow_probe[] = {

allow_probe -> dw_i2c_hwmon_class_dmi

> +	{
> +		.ident = "Qtechnology QT5222",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Qtechnology"),

> +			DMI_MATCH(DMI_PRODUCT_NAME, "QT5222")

Comma is missed.

> +		}
> +	},

> +

Redundant.

> +	{ }
> +};

-- 
With Best Regards,
Andy Shevchenko