RE: [PATCH v2] 9p: retrieve fid from file when file instance exist.

[Jianyong Wu]

Hi Dominique,

> -----Original Message-----
> From: Dominique Martinet <asmadeus@xxxxxxxxxxxxx>
> Sent: Thursday, July 2, 2020 3:56 PM
> To: Jianyong Wu <Jianyong.Wu@xxxxxxx>
> Cc: ericvh@xxxxxxxxx; lucho@xxxxxxxxxx; v9fs-
> developer@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Steve
> Capper <Steve.Capper@xxxxxxx>; Kaly Xin <Kaly.Xin@xxxxxxx>; Justin He
> <Justin.He@xxxxxxx>; Wei Chen <Wei.Chen@xxxxxxx>
> Subject: Re: [PATCH v2] 9p: retrieve fid from file when file instance exist.
>
> Jianyong Wu wrote on Thu, Jul 02, 2020:
> > Yeah, should check fid before "v9fs_fid_lookup", how about
> >
> > if (iattr->ia_valid & ATTR_FILE) {
> >                 fid = iattr->ia_file->private_data;
> >                 WARN_ON(!fid);
> >  }
> > If (!fid)
> > fid = v9fs_fid_lookup(dentry);
>
> Yes, that would be fine.
>
Ok, I will apply this change both in vfs_inode.c and vfs_inode_dotl.c next version.

Thanks
Jianyong

> --
> Dominique
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.