Re: [PATCH v9 3/3] media: vimc: Add a control to display info on test image

[kernel test robot]

Hi Kaaira,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v5.8-rc3 next-20200702]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kaaira-Gupta/media-Add-colors-order-and-other-info-over-test-image/20200701-213129
base:   git://linuxtv.org/media_tree.git master
config: arm-randconfig-r023-20200702 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   arm-linux-gnueabi-ld: section .data VMA [0000000080008000,0000000080346f97] overlaps section .text VMA [000000007f0801c0,0000000080b4332f]
   arm-linux-gnueabi-ld: drivers/media/test-drivers/vimc/vimc-sensor.o: in function `vimc_sen_process_frame':
>> drivers/media/test-drivers/vimc/vimc-sensor.c:227: undefined reference to `__aeabi_uldivmod'

vim +227 drivers/media/test-drivers/vimc/vimc-sensor.c

   192	
   193	static void *vimc_sen_process_frame(struct vimc_ent_device *ved,
   194					    const void *sink_frame)
   195	{
   196		struct vimc_sen_device *vsen = container_of(ved, struct vimc_sen_device,
   197							    ved);
   198		const unsigned int line_height = 16;
   199		u8 *basep[TPG_MAX_PLANES][2];
   200		unsigned int line = 1;
   201		char str[100];
   202	
   203		tpg_fill_plane_buffer(&vsen->tpg, 0, 0, vsen->frame);
   204		tpg_calc_text_basep(&vsen->tpg, basep, 0, vsen->frame);
   205		switch (vsen->osd_value) {
   206		case VIMC_SEN_OSD_SHOW_ALL: {
   207			const char *order = tpg_g_color_order(&vsen->tpg);
   208	
   209			tpg_gen_text(&vsen->tpg, basep, line++ * line_height,
   210				     16, order);
   211			snprintf(str, sizeof(str),
   212				 "brightness %3d, contrast %3d, saturation %3d, hue %d ",
   213				 vsen->tpg.brightness,
   214				 vsen->tpg.contrast,
   215				 vsen->tpg.saturation,
   216				 vsen->tpg.hue);
   217			tpg_gen_text(&vsen->tpg, basep, line++ * line_height, 16, str);
   218			snprintf(str, sizeof(str), "sensor size: %dx%d",
   219				 vsen->mbus_format.width,
   220				 vsen->mbus_format.height);
   221			tpg_gen_text(&vsen->tpg, basep, line++ * line_height, 16, str);
   222			fallthrough;
   223		}
   224		case VIMC_SEN_OSD_SHOW_COUNTERS: {
   225			unsigned int ms;
   226	
 > 227			ms = (ktime_get_ns() - vsen->start_stream_ts) / 1000000;
   228			snprintf(str, sizeof(str), "%02d:%02d:%02d:%03d",
   229				 (ms / (60 * 60 * 1000)) % 24,
   230				 (ms / (60 * 1000)) % 60,
   231				 (ms / 1000) % 60,
   232				 ms % 1000);
   233			tpg_gen_text(&vsen->tpg, basep, line++ * line_height, 16, str);
   234			break;
   235		}
   236		case VIMC_SEN_OSD_SHOW_NONE:
   237		default:
   238			break;
   239		}
   240	
   241		return vsen->frame;
   242	}
   243	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip