Re: [PATCH v2 14/17] arm64: Kill __smp_cross_call and co

[Marc Zyngier]

On 2020-06-25 19:25, Valentin Schneider wrote:
> On 24/06/20 20:58, Marc Zyngier wrote:
> > @@ -852,8 +841,7 @@ void arch_send_wakeup_ipi_mask(const struct 
> > cpumask *mask)
> >  #ifdef CONFIG_IRQ_WORK
> >  void arch_irq_work_raise(void)
> >  {
> > -	if (__smp_cross_call)
> > -		smp_cross_call(cpumask_of(smp_processor_id()), IPI_IRQ_WORK);
> > +	smp_cross_call(cpumask_of(smp_processor_id()), IPI_IRQ_WORK);
>
> AIU the following commit:
>
>   eb631bb5bf5b ("arm64: Support arch_irq_work_raise() via self IPIs")
>
> It seems arm64 hasn't needed that check since
>
>   4b3dc9679cf7 ("arm64: force CONFIG_SMP=y and remove redundant 
> #ifdefs")
>
> Did I get that right?

Indeed. SMP implies being able to IPI, and thus the check has been
irrelevant for some time now.

Thanks,

        M.
--
Jazz is not dead. It just smells funny...