Re: [PATCH net] net: dsa: microchip: set the correct number of ports

From: Andrew Lunn
Date: Thu Jul 02 2020 - 09:50:21 EST


On Thu, Jul 02, 2020 at 12:44:50PM +0300, Codrin Ciubotariu wrote:
> The number of ports is incorrectly set to the maximum available for a DSA
> switch. Even if the extra ports are not used, this causes some functions
> to be called later, like port_disable() and port_stp_state_set(). If the
> driver doesn't check the port index, it will end up modifying unknown
> registers.
>
> Fixes: b987e98e50ab ("dsa: add DSA switch driver for Microchip KSZ9477")
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@xxxxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Thanks for the minimum patch.

If you wait about a week, net will get merged into net-next. You can
then submit a refactoring patch based on your previous version.

Andrew