Re: [PATCH 7/9] soundwire: intel/cadence: merge Soundwire interrupt handlers/threads

From: Pierre-Louis Bossart
Date: Thu Jul 02 2020 - 11:03:00 EST



On 7/2/20 2:35 AM, Liao, Bard wrote:
-----Original Message-----
From: Vinod Koul <vkoul@xxxxxxxxxx>
Sent: Wednesday, July 1, 2020 1:42 PM
To: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
Cc: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>; alsa-devel@xxxxxxxxxxxxxxxx;
tiwai@xxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
ranjani.sridharan@xxxxxxxxxxxxxxx; hui.wang@xxxxxxxxxxxxx;
broonie@xxxxxxxxxx; srinivas.kandagatla@xxxxxxxxxx; jank@xxxxxxxxxxx; Lin,
Mengdong <mengdong.lin@xxxxxxxxx>; Blauciak, Slawomir
<slawomir.blauciak@xxxxxxxxx>; Kale, Sanyog R <sanyog.r.kale@xxxxxxxxx>;
rander.wang@xxxxxxxxxxxxxxx; Liao, Bard <bard.liao@xxxxxxxxx>
Subject: Re: [PATCH 7/9] soundwire: intel/cadence: merge Soundwire interrupt
handlers/threads

On 30-06-20, 11:46, Pierre-Louis Bossart wrote:

Is this called from irq context or irq thread or something else?

from IRQ thread, hence the name, see pointers above.

The key part is that we could only make the hardware work as intended by
using a single thread for all interrupt sources, and that patch is just the
generalization of what was implemented for HDaudio in mid-2019 after
months
of lost interrupts and IPC errors. See below the code from
sound/soc/sof/intel/hda.c for interrupt handling.

Sounds good. Now that you are already in irq thread, does it make sense
to spawn a worker thread for this and handle it there? Why not do in the
irq thread itself. Using a thread kind of defeats the whole point behind
concept of irq threads

Not sure If you are talking about cdns_update_slave_status_work().
The reason we need to spawn a worker thread in sdw_cdns_irq() is
that we will do sdw transfer which will generate an interrupt when
a slave interrupt is triggered. And the handler will not be invoked if the
previous handler is not return yet.
Please see the scenario below for better explanation.
1. Slave interrupt arrives
2.1 Try to read Slave register and waiting for the transfer response
2.2 Get the transfer response interrupt and finish the sdw transfer.
3. Finish the Slave interrupt handling.

Interrupts are triggered in step 1 and 2.2, but step 2.2's handler will not be
invoked if step 1's handler is not return yet.
What we do is to spawn a worker thread to do step 2 and return from step 1.
So the handler can be invoked when the transfer response interrupt arrives.

To build on Bard's correct answer, the irq thread only takes care of 'immediate' actions, such as command completion, parity or bus clash errors. The rest of the work can be split in
a) changes to device state, usually for attachment and enumeration. This is rather slow and will entail regmap syncs.
b) device interrupts - typically only for jack detection which is also rather slow.

Since this irq thread function is actually part of the entire HDaudio controller interrupt handling, we have to defer the work for cases a) and b) and re-enable the HDaudio interrupts at the end of the irq thread function - see the code I shared earlier.

In addition, both a) and b) will result in transactions over the bus, which will trigger interrupts to signal the command completions. In other words, because of the asynchronous nature of the transactions, we need a two-level implementation. If you look at the previous solution it was the same, the commands were issued in the irq thread and the command completion was handled in the handler, since we had to make the handler minimal with a global GIE interrupt disable we kept the same hierarchy to deal with commands but move it up one level.

You could argue that maybe a worker thread is not optimal and could be replaced by something better/faster. Since the jack detection is typically handled with a worker thread in all ASoC codec drivers, we didn't feel the need to optimize further. We did not see any performance impact with this change.

Does this answer to your concern?