Re: [PATCH v1 2/2] qlcninc: use generic power management

[Jakub Kicinski]

On Thu,  2 Jul 2020 12:06:32 +0530 Vaibhav Gupta wrote:
> With legacy PM, drivers themselves were responsible for managing the
> device's power states and takes care of register states. And they use PCI
> helper functions to do it.
> 
> After upgrading to the generic structure, PCI core will take care of
> required tasks and drivers should do only device-specific operations.
> 
> .suspend() calls __qlcnic_shutdown, which then calls qlcnic_82xx_shutdown;
> .resume()  calls __qlcnic_resume,   which then calls qlcnic_82xx_resume;
> 
> Both ...82xx..() are define in
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c and are used only in
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c.
> 
> Hence upgrade them and remove PCI function calls, like pci_save_state() and
> pci_enable_wake(), inside them
> 
> Compile-tested only.
> 
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@xxxxxxxxx>

drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c: In function âqlcnic_82xx_shutdownâ:
drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c:1652:6: warning: unused variable âretvalâ [-Wunused-variable]
 1652 |  int retval;
      |      ^~~~~~