Re: [PATCH net-next 5/7] devlink: Add devlink health port reporters API

From: Moshe Shemesh
Date: Thu Jul 02 2020 - 13:48:13 EST



On 7/2/2020 7:40 PM, Jakub Kicinski wrote:
On Thu, 2 Jul 2020 18:08:11 +0300 Moshe Shemesh wrote:
From: Vladyslav Tarasiuk <vladyslavt@xxxxxxxxxxxx>

In order to use new devlink port health reporters infrastructure, add
corresponding constructor and destructor functions.

Signed-off-by: Vladyslav Tarasiuk <vladyslavt@xxxxxxxxxxxx>
Reviewed-by: Moshe Shemesh <moshe@xxxxxxxxxxxx>
Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxxxx>
net/core/devlink.c:5361: warning: Function parameter or member 'port' not described in 'devlink_port_health_reporter_create'
net/core/devlink.c:5361: warning: Excess function parameter 'devlink_port' description in 'devlink_port_health_reporter_create'
net/core/devlink.c:5462: warning: Excess function parameter 'port' description in 'devlink_port_health_reporter_destroy'


I will resend with a fix. Thanks.