Re: [PATCH v6 5/6] mm/swap: implement workingset detection for anonymous LRU

[Joonsoo Kim]

2020ë 7ì 2ì (ë) ìí 10:37, Vlastimil Babka <vbabka@xxxxxxx>ëì ìì:
>
> On 6/17/20 7:26 AM, js1304@xxxxxxxxx wrote:
> > From: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
> >
> > This patch implements workingset detection for anonymous LRU.
> > All the infrastructure is implemented by the previous patches so this patch
> > just activates the workingset detection by installing/retrieving
> > the shadow entry.
> >
> > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
>
> Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
>
> > diff --git a/mm/workingset.c b/mm/workingset.c
> > index 8395e60..3769ae6 100644
> > --- a/mm/workingset.c
> > +++ b/mm/workingset.c
> > @@ -353,8 +353,9 @@ void workingset_refault(struct page *page, void *shadow)
> >       /*
> >        * Compare the distance to the existing workingset size. We
> >        * don't activate pages that couldn't stay resident even if
> > -      * all the memory was available to the page cache. Whether
> > -      * cache can compete with anon or not depends on having swap.
> > +      * all the memory was available to the workingset. Whether
> > +      * workingset competetion need to consider anon or not depends
>
>                       competition needs

Will fix it.

Thanks.