Re: [PATCH v4] selftests: tpm: upgrade TPM2 tests from Python 2 to Python 3
From: Pengfei Xu
Date: Thu Jul 02 2020 - 21:10:20 EST
Thanks a lot Jarkko and Shuah!
BR.
Thanks!
On 2020-07-02 at 15:32:49 -0600, Shuah Khan wrote:
> On 7/2/20 1:44 PM, Jarkko Sakkinen wrote:
> > On Fri, Jun 26, 2020 at 11:40:52AM +0800, Pengfei Xu wrote:
> > > Python 2 is no longer supported by the Python upstream project, so
> > > upgrade TPM2 tests to Python 3.
> > >
> > > Signed-off-by: Pengfei Xu <pengfei.xu@xxxxxxxxx>
> >
> > I think that it's perfect now. Thank you.
> >
> > Also
> >
> > 1. I checked that scripts/checkpatch.pl did not report any errors.
> > 2. sudo python3 -m unittest -v tpm2_tests.SmokeTest
> > 3. sudo python3 -m unittest -v tpm2_tests.SpaceTest
> >
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> > Tested-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> >
> > Shuah, I could pick this up after your PR (with my earlier fixes) lands
> > to mainline, and sort out possible merge conflicts if they uprise. Is
> > this fine by you?
> >
>
> Yes. I will apply them as soon as PR clears and hopefully they can go
> into rc5.
>
> thanks,
> -- Shuah
>