Re: [PATCH v2 06/15] perf ftrace: add option '-m/--buffer-size' to set per-cpu buffer size

[Namhyung Kim]

On Sat, Jun 27, 2020 at 10:38 PM Changbin Du <changbin.du@xxxxxxxxx> wrote:
>
> This adds an option '-m/--buffer-size' to allow us set the size of per-cpu
> tracing buffer.
>
> Signed-off-by: Changbin Du <changbin.du@xxxxxxxxx>
> ---
[SNIP]
> @@ -555,6 +575,8 @@ int cmd_ftrace(int argc, const char **argv)
>                     "Max depth for function graph tracer"),
>         OPT_UINTEGER('d', "delay", &ftrace.initial_delay,
>                      "ms to wait before starting tracing after program start"),
> +       OPT_UINTEGER('m', "buffer-size", &ftrace.buffer_size_kb,
> +                    "size of per cpu buffer in kb"),

It'd be nice if we support units as a suffix (like perf record). e.g. -m 4M

Thanks
Namhyung

>         OPT_END()
>         };
>
> --
> 2.25.1
>