Re: [PATCH v2] HID: i2c-hid: Use block reads when possible to save power

[Jarkko Nikula]

Hi

On 7/1/20 6:00 PM, Sultan Alsawaf wrote:
> On Wed, Jul 01, 2020 at 11:04:01AM +0300, Jarkko Nikula wrote:
> > On 6/29/20 8:43 PM, Sultan Alsawaf wrote:
> > > Hmm, for some reason in 5.8 I get the same problem, but 5.7 is fine. Could you
> > > try this on 5.7 and see if it works?
> > >
> > > In the meantime I'll bisect 5.8 to see why it's causing problems for me...
> > I see the same issue on top of v5.7:
>
> Try reverting my "i2c: designware: Only check the first byte for SMBus block
> read length" patch and apply the following change instead:
This combination (the diff and this HID patch) works on top of v5.7.

I tried also these other combinations:

v5.7
- HID patch + this diff -> ok
- HID patch -> not ok
- HID + acked i2c-dw patch -> acked i2c-dw patch doesn't apply

v5.8-rc3
- acked i2c-dw patch -> ok
- HID patch -> nok
- HID patch + acked i2c-dw patch -> nok
- HID patch + this diff -> diff doesn't apply

Hopefully gives some glue. I'll be out of office for a few weeks and 
unfortunately cannot test patches meanwhile.

Jarkko