Re: [PATCH 2/2] PM / devfreq: Add governor flags to clarify the features

[Chanwoo Choi]

Hi Dmitry,

On Fri, Jul 3, 2020 at 7:46 PM Dmitry Osipenko <digetx@xxxxxxxxx> wrote:
>
> 03.07.2020 13:08, Chanwoo Choi ÐÐÑÐÑ:
> > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> > index e94a27804c20..620ecd250d7c 100644
> > --- a/drivers/devfreq/tegra30-devfreq.c
> > +++ b/drivers/devfreq/tegra30-devfreq.c
> > @@ -765,10 +765,12 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
> >
> >  static struct devfreq_governor tegra_devfreq_governor = {
> >       .name = "tegra_actmon",
> > +     .flag = DEVFREQ_GOV_FLAG_ATTR_COMMON
> > +             | DEVFREQ_GOV_FLAG_ATTR_POLLING_INTERVAL,
>
> Hello, Chanwoo!
>
> There is a typo here, it should be ".attr = ".

Ah. Sorry. After changed the name, I didn't test COMPILE_TEST.

>
> > +     .flag = DEVFREQ_GOV_FLAG_FLAG_IMMUTABLE,
> > +             | DEVFREQ_GOV_FLAG_FLAG_IRQ_DRIVEN,
>
> There is a typo here too FLAG_FLAG ^

Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics