Re: [PATCH v3] HID: logitech-hidpp: add support for Logitech G533 headset

[Filipe Laíns]

On Sat, 2020-07-04 at 02:47 +0200, Kamil DomaÅski wrote:
> Changelog:
>   v2:
>   - changed charging status parsing to account for invalid states
>   v3:
>   - rebased against Linux v5.7
>   - changed variable naming in hidpp20_adc_map_status_voltage
>     to camel case
>   - corrected comment styling in hidpp_battery_get_property
>   - dropped usage of test_bit macro in hidpp20_adc_map_status_voltage
>     to avoid using `long` type
>   - added bit flag definitions in hidpp20_adc_map_status_voltage
> 
> Signed-off-by: Kamil DomaÅski <kamil@xxxxxxxxxxx>

Seems like my concerns were address and the patch looks correct.

Benjamin, Jiri, are there any implications to keep in mind of always
polling the device every time we need to read the voltage? I don't
expect anything major, I just thought there might something there I
should keep in the back of my mind. 

Cheers,
Filipe LaÃns

Attachment: signature.asc
Description: This is a digitally signed message part