Re: [PATCH] drivers/net/wan/lapbether: Fixed the value of hard_header_len

From: David Miller
Date: Sat Jul 04 2020 - 20:52:49 EST


From: Xie He <xie.he.0141@xxxxxxxxx>
Date: Fri, 3 Jul 2020 22:12:46 -0700

> When transmitting data from upper layers or from AF_PACKET sockets,
> this driver will first remove a pseudo header of 1 byte,
> then the lapb module will prepend the LAPB header of 2 or 3 bytes,
> then this driver will prepend a length field of 2 bytes,
> then the underlying Ethernet device will prepend its own header.

Please add something like this above text to a comment:

> @@ -324,6 +323,8 @@ static int lapbeth_new_device(struct net_device *dev)
> if (!ndev)
> goto out;
>
> + ndev->hard_header_len = -1 + 3 + 2 + dev->hard_header_len;
> +

Above this new line so that someone reading the code can understand
these magic numbers and what they mean.

Thank you.