Re: [PATCH V6] serial: msm_geni_serial_console : Add Earlycon support
From: kernel test robot
Date: Sun Jul 05 2020 - 02:12:55 EST
Hi Akash,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tty/tty-testing]
[also build test WARNING on usb/usb-testing v5.8-rc3 next-20200703]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Akash-Asthana/serial-msm_geni_serial_console-Add-Earlycon-support/20200622-181041
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: m68k-randconfig-r003-20200705 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
drivers/tty/serial/msm_geni_serial_console.c: In function 'msm_geni_serial_earlycon_setup':
>> drivers/tty/serial/msm_geni_serial_console.c:400:6: warning: variable 'rx_stale' set but not used [-Wunused-but-set-variable]
400 | u32 rx_stale = 0;
| ^~~~~~~~
>> drivers/tty/serial/msm_geni_serial_console.c:398:6: warning: variable 'rx_parity_cfg' set but not used [-Wunused-but-set-variable]
398 | u32 rx_parity_cfg = 0;
| ^~~~~~~~~~~~~
>> drivers/tty/serial/msm_geni_serial_console.c:397:6: warning: variable 'rx_trans_cfg' set but not used [-Wunused-but-set-variable]
397 | u32 rx_trans_cfg = 0;
| ^~~~~~~~~~~~
vim +/rx_stale +400 drivers/tty/serial/msm_geni_serial_console.c
388
389 static int __init
390 msm_geni_serial_earlycon_setup(struct earlycon_device *dev,
391 const char *opt)
392 {
393 struct uart_port *uport = &dev->port;
394 int ret = 0;
395 u32 tx_trans_cfg = 0;
396 u32 tx_parity_cfg = 0;
> 397 u32 rx_trans_cfg = 0;
> 398 u32 rx_parity_cfg = 0;
399 u32 stop_bit = 0;
> 400 u32 rx_stale = 0;
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip