RE: [PATCH v2] rtc: rtc-ds1374: wdt: Use watchdog core for watchdog part

[Johnson CH Chen (éæå)]

Hi,

> > > > +	ret = devm_watchdog_register_device(&client->dev, &ds1374->wdt);
> > > >  	if (ret) {
> > > > -		misc_deregister(&ds1374_miscdev);
> > > > +		dev_err(&client->dev, "failed to register DS1374 watchdog
> > > > +device\n");
> 
> There was no error message before, I don't think this one is necessary.
> 
> > > >  		return ret;
> > > >  	}
> > > > -	ds1374_wdt_settimeout(131072);
> > > > +
> > > > +	dev_info(&client->dev, "DS1374 watchdog device enabled\n");
> > >
> > > Is that necessary ?
> > >
> >
> > I think it's good to show watchdog initial timeout. I'll include above
> suggestions in v3, thanks!
> >
> 
> No, please avoid adding more strings in that driver.
> 

I get it, thanks for review!

Best regards,
Johnson
> 
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com