Re: [PATCH] exfat: implement "quiet" option for setattr

[Namjae Jeon]

2020-07-06 17:22 GMT+09:00, Ju Hyung Park <qkrwngud825@xxxxxxxxx>:
> Hi Namjae.
Hi Juhyung,
>
> Looks like I ported this incorrectly from the previous sdFAT base.
>
> I'll fix, test again and send v2.
Okay:) Thanks!
>
> Thanks.
>
> On Thu, Jul 2, 2020 at 2:16 PM Namjae Jeon <namjae.jeon@xxxxxxxxxxx> wrote:
>>
>> >
>> >       if (((attr->ia_valid & ATTR_UID) &&
>> >            !uid_eq(attr->ia_uid, sbi->options.fs_uid)) || @@ -322,6
>> > +325,12 @@ int
>> > exfat_setattr(struct dentry *dentry, struct iattr *attr)
>> >               goto out;
>> You should remove goto statement and curly braces here to reach if error
>> condition.
>> >       }
>> >
>> > +     if (error) {
>> > +             if (sbi->options.quiet)
>> > +                     error = 0;
>> > +             goto out;
>> > +     }
>>
>