Re: [PATCH] PCI: dwc: pci-dra7xx: fix runtime pm imbalance on error

[Lorenzo Pieralisi]

On Wed, May 20, 2020 at 04:47:56PM +0800, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> it returns an error code. Thus a pairing decrement is needed on
> the error handling path to keep the counter balanced.
> 
> Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>
> ---
>  drivers/pci/controller/dwc/pci-dra7xx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
> index 3b0e58f2de58..8fd9f2281e02 100644
> --- a/drivers/pci/controller/dwc/pci-dra7xx.c
> +++ b/drivers/pci/controller/dwc/pci-dra7xx.c
> @@ -1000,9 +1000,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
>  	return 0;
>  
>  err_gpio:
> -	pm_runtime_put(dev);
> -
>  err_get_sync:
> +	pm_runtime_put(dev);
>  	pm_runtime_disable(dev);
>  	dra7xx_pcie_disable_phy(dra7xx);

Applied to pci/runtime-pm, thanks.

Lorenzo