Re: [PATCH v4 14/18] nitro_enclaves: Add Kconfig for the Nitro Enclaves driver

[Alexander Graf]

On 22.06.20 22:03, Andra Paraschiv wrote:
> Signed-off-by: Andra Paraschiv <andraprs@xxxxxxxxxx>
> ---
> Changelog
>
> v3 -> v4
>
> * Add PCI and SMP dependencies.
>
> v2 -> v3
>
> * Remove the GPL additional wording as SPDX-License-Identifier is
>    already in place.
>
> v1 -> v2
>
> * Update path to Kconfig to match the drivers/virt/nitro_enclaves
>    directory.
> * Update help in Kconfig.
> ---
>   drivers/virt/Kconfig                |  2 ++
>   drivers/virt/nitro_enclaves/Kconfig | 16 ++++++++++++++++
>   2 files changed, 18 insertions(+)
>   create mode 100644 drivers/virt/nitro_enclaves/Kconfig
>
> diff --git a/drivers/virt/Kconfig b/drivers/virt/Kconfig
> index cbc1f25c79ab..80c5f9c16ec1 100644
> --- a/drivers/virt/Kconfig
> +++ b/drivers/virt/Kconfig
> @@ -32,4 +32,6 @@ config FSL_HV_MANAGER
>   	     partition shuts down.
>   
>   source "drivers/virt/vboxguest/Kconfig"
> +
> +source "drivers/virt/nitro_enclaves/Kconfig"
>   endif
> diff --git a/drivers/virt/nitro_enclaves/Kconfig b/drivers/virt/nitro_enclaves/Kconfig
> new file mode 100644
> index 000000000000..69e41aa2222d
> --- /dev/null
> +++ b/drivers/virt/nitro_enclaves/Kconfig
> @@ -0,0 +1,16 @@
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
> +
> +# Amazon Nitro Enclaves (NE) support.
> +# Nitro is a hypervisor that has been developed by Amazon.
> +
> +config NITRO_ENCLAVES
> +	tristate "Nitro Enclaves Support"
> +	depends on HOTPLUG_CPU && PCI && SMP

Let's also depend on ARM64 || X86, so that we don't burden all of the 
other archs that are not available in EC2 today with an additional 
config option to think about.

Alex



Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879